Use label for "Follow link" command's tooltip#110917
Use label for "Follow link" command's tooltip#110917alexdima merged 3 commits intomicrosoft:masterfrom
Conversation
|
Doesn't this change also mean I won't be able to preview the target of an http(s) link? Maybe OK to omit the query string from what the hover currently shows. Also, based on code reading I expected the link text in your screenshot to read "Execute command" rather than "Follow link". |
True. Is that an intended use-case, or simply a side-effect of the current behavior? The PR could be adjusted so that it only uses the label if
That would be an improvement, but I think showing the command name would still be undesirable behavior, as it's unexpected and not self-explanatory to anyone who doesn't know what command URIs are, as they're an implementation detail.
I believe that's because it's a Markdown document, and the |
|
🤷 Let's see what a team member says when this PR gets looked at. |
|
I agree that the markdown tooltip is too much. Other test cases (http and file links): <!--
http://www.example.com
-->
<script src="script.js"></script> |
|
Thank you! |
Currently hovering over the "Follow link" command will show the URI for the command in text form. This PR changes it to showing the label as the tooltip.
Avoids this: