Fixing ListWidget escape button behavior#110760
Merged
joaomoreno merged 2 commits intomicrosoft:masterfrom Nov 25, 2020
aasimkhan30:aasim/fix/listWidgetEscape
Merged
Fixing ListWidget escape button behavior#110760joaomoreno merged 2 commits intomicrosoft:masterfrom aasimkhan30:aasim/fix/listWidgetEscape
joaomoreno merged 2 commits intomicrosoft:masterfrom
aasimkhan30:aasim/fix/listWidgetEscape
Conversation
Updating forked vscode 11/16/20
aasimkhan30
changed the title
Member
|
Have you tested this? In what feature? I ask because keyboard shortcuts are handled in a special way in the workbench, so this code shouldn't run on a lot of list instances. |
Contributor
Author
|
I did test this in quickInput component and it seems to work fine. Is there anything in particular that you want me to test? |
Member
|
Can you please provide a screen recording of the issue? |
joaomoreno
added
list-widget
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am changing how escape keys works in ListWidget.
Currently, the focus gets trapped inside the component when an escape key is pressed.
My proposed change unselects all the items on first escape (current logic) and then it lets the default behavior take over.