Skip to content

Mark .ember-cli as jsonc instead of json#110541

Merged
aeschli merged 1 commit intomicrosoft:masterfrom
loganrosen:ember-cli
Nov 13, 2020
Merged

Mark .ember-cli as jsonc instead of json#110541
aeschli merged 1 commit intomicrosoft:masterfrom
loganrosen:ember-cli

Conversation

@loganrosen
Copy link
Member

The .ember-cli file generated by Ember is JSON with Comments (jsonc): https://github.com/ember-cli/ember-cli/blob/master/blueprints/app/files/.ember-cli

I've changed its associated language accordingly because it being the JSON type by default causes red underlines in the generated file.

This PR fixes #110540

The .ember-cli file generated by Ember is JSON with Comments (jsonc): https://github.com/ember-cli/ember-cli/blob/master/blueprints/app/files/.ember-cli

I've changed its associated language accordingly because it being the JSON type by default causes red underlines in the generated file.
@aeschli aeschli added this to the November 2020 milestone Nov 13, 2020
@aeschli aeschli added the languages-basic Basic language support issues label Nov 13, 2020
@aeschli aeschli merged commit c5ee747 into microsoft:master Nov 13, 2020
@aeschli
Copy link
Contributor

aeschli commented Nov 13, 2020

Thanks @loganrosen !

@loganrosen loganrosen deleted the ember-cli branch November 13, 2020 22:02
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

languages-basic Basic language support issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.ember-cli has incorrect language association

2 participants