Add a setting to include word based suggestions regardless of the language#110494
Merged
jrieken merged 1 commit intomicrosoft:masterfrom Nov 13, 2020
usernamehw:word_suggestion_any_language
Merged
Add a setting to include word based suggestions regardless of the language#110494jrieken merged 1 commit intomicrosoft:masterfrom usernamehw:word_suggestion_any_language
jrieken merged 1 commit intomicrosoft:masterfrom
usernamehw:word_suggestion_any_language
Conversation
jrieken
reviewed
Nov 12, 2020
| 'editor.wordBasedSuggestionsOnlySameLanguage': { | ||
| type: 'boolean', | ||
| default: true, | ||
| description: nls.localize('wordBasedSuggestionsOnlySameLanguage', "Controls whether word based completions should be included from opened documents of the same language or any language.") |
Member
There was a problem hiding this comment.
Looking, good. I might remodel this into a enum which goes like wordBasedSuggestionSource: 'currentDocument', 'sameLanguageDocuments', 'allDocuments'. That will allow folks to go back to old behaviour as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A setting for #5312