Fix progress bit overflow bug#110411
Merged
bpasero merged 2 commits intomicrosoft:masterfrom Nov 12, 2020
Merged
Conversation
bit: 100% width, parent 5000% width, translateX(4900%) + bitwidth(100%) = parentwidth(5000%). 4950% will make half of progress bit overflow. :p
Member
|
Thanks 👍 |
meganrogge
pushed a commit
that referenced
this pull request
Nov 18, 2020
* Fix progress bit overflow bug bit: 100% width, parent 5000% width, translateX(4900%) + bitwidth(100%) = parentwidth(5000%). 4950% will make half of progress bit overflow. :p * Set progress bit to center at 50% animate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parent width: 5000%
progress bit width: 100%
translateX should be:
translateX(4950%)will make half of progress bit overflow. :p