Fixes terminal lags while scrollling when printing long line#110213
Merged
Tyriar merged 1 commit intomicrosoft:masterfrom Nov 9, 2020
Merged
Fixes terminal lags while scrollling when printing long line#110213Tyriar merged 1 commit intomicrosoft:masterfrom
Tyriar merged 1 commit intomicrosoft:masterfrom
Conversation
rheh
approved these changes
Nov 9, 2020
rheh
left a comment
rheh
left a comment
There was a problem hiding this comment.
LGTM
Only suggestion I'd have is for the constant to be moved into a place which the new terminal code and link detector can use; rather that duplicating?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #100338
Copied the string max length from
vscode/src/vs/workbench/contrib/debug/browser/linkDetector.ts
Line 27 in 776541c