#109255 - Add encoding description to settings "File: Encoding" drop-down#109551
Merged
roblourens merged 3 commits intomicrosoft:masterfrom Nov 10, 2020
Merged
Conversation
|
|
Member
|
This looks like a good start, we are stabilizing a release this week and I will review it in depth next week. |
Member
|
Made a small change to remove the new registered color, and match the styling of the editor encoding quick pick. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #109255 by adding the encoding key in a new detail field under the "File: Encoding" dropdown of Settings, this is similar to how encodings are displayed in the "Select file encoding to save with" action.
Questions
Screenshots
