add 'deleteWordEntire' command#109511
Merged
alexdima merged 5 commits intomicrosoft:masterfrom Nov 19, 2020
Merged
Conversation
|
|
|
I have this through an extension, and find the feature to be very useful. It would make a great contribution, imo. |
rheh
reviewed
Nov 3, 2020
rheh
left a comment
rheh
left a comment
There was a problem hiding this comment.
Do we need add some tests to wordOperations.test.ts to cover the new function?
rheh
reviewed
Nov 3, 2020
Contributor
Author
|
Thank you. |
gbumanzordev
approved these changes
Nov 15, 2020
alexdima
force-pushed
the
deleteWordEntire
branch
from
77c511c to
6fd7aeb
Compare
alexdima
force-pushed
the
deleteWordEntire
branch
from
6fd7aeb to
2a49954
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #109510
We added a new shortcut key ‘deleteWordEntire’.
‘deleteWordLeft’ or ‘deleteWordRight’ commands already exist. However, it is rare that we want to delete letters in only one side from the cursor.
This ‘deleteWordEntire’ command can be executed by pressing ‘ctrl + Shift + U’ (on Linux). This command deletes a word the cursor is pointing to. Even if the cursor is in the middle of the word, we can delete the whole word (not only left or right side of the cursor). Furthermore, this command also deletes the following whitespace. For example,
So this command is convenient and will definitely improve our development efficency.