message "Would you like to stage all chages?"#109272
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom Oct 28, 2020
Merged
message "Would you like to stage all chages?"#109272joaomoreno merged 1 commit intomicrosoft:masterfrom
joaomoreno merged 1 commit intomicrosoft:masterfrom
Conversation
The old message, ``` Would you like to automatically stage all your changes and commit them directly? ``` sounds like clicking _Yes_ will do this _automatically_ from now on, which is not the case. I removed _automatically_.
Member
|
While the current message might not be correct, the proposed change also fails to address the fact that a setting will be turned on to allow to commit unstaged changes directly, every time the user tries to commit and there are no staged changes. Any other proposals? |
Contributor
Author
|
The current dialog is this:
The option Yes does not have a permanent effect, which is why I made this PR. It sounds like you are referring to the Always option, but in that case, the permanent effect is communicated by the button's label. |
Member
|
You're absolutely right! Thanks for the pointer and the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When clicking "commit" with no staged changes, the old message:
sounds like clicking Yes will do this automatically from now on, which is not the case. I removed automatically.
This PR fixes #