Typo: Uncommited → Uncommitted#109119
Merged
eamodio merged 1 commit intomicrosoft:masterfrom Nov 12, 2020
Merged
Conversation
ItzLevvie
suggested changes
Oct 21, 2020
| const date = new Date(); | ||
|
|
||
| const item = new GitTimelineItem('', index ? '~' : 'HEAD', localize('git.timeline.uncommitedChanges', 'Uncommited Changes'), date.getTime(), 'working', 'git:file:working'); | ||
| const item = new GitTimelineItem('', index ? '~' : 'HEAD', localize('git.timeline.uncommitedChanges', 'Uncommitted Changes'), date.getTime(), 'working', 'git:file:working'); |
Contributor
There was a problem hiding this comment.
Suggested change
| const item = new GitTimelineItem('', index ? '~' : 'HEAD', localize('git.timeline.uncommitedChanges', 'Uncommitted Changes'), date.getTime(), 'working', 'git:file:working'); | |
| const item = new GitTimelineItem('', index ? '~' : 'HEAD', localize('git.timeline.uncommittedChanges', 'Uncommitted Changes'), date.getTime(), 'working', 'git:file:working'); |
Contributor
Author
There was a problem hiding this comment.
I skipped the localization key with the assumption that translations (which are external) would need to also be updated.
atherkhan
approved these changes
Nov 11, 2020
Contributor
|
Looks good -- Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Timeline extension contains a typo when there are uncommitted changes: "Uncommited Changes". This fixes that.