fix download issues in webviews#108603
Merged
mjbvz merged 2 commits intomicrosoft:masterfrom Oct 14, 2020
Merged
Conversation
Contributor
Author
|
I am pretty sure other Visual Studio Code extension developers will get the same problem... |
Collaborator
|
Make sure to also add this in |
|
|
Contributor
Author
|
Done. I was wondering why there is typescript + javascript here. Modifying typescript only do not have effect on the final build. Is there a transition ongoing ? |
Collaborator
|
Thanks! |
jmannanc
pushed a commit
to jmannanc/vscode
that referenced
this pull request
Oct 26, 2020
* fix download issues in webviews * also add allow-download in ts src
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #108602