Typo hightlight -> highlight#108451
Merged
alexdima merged 2 commits intomicrosoft:masterfrom Nov 16, 2020
justjosias:patch-1
Merged
Typo hightlight -> highlight#108451alexdima merged 2 commits intomicrosoft:masterfrom justjosias:patch-1
alexdima merged 2 commits intomicrosoft:masterfrom
justjosias:patch-1
Conversation
The original member was named `_renderLineHightlightOnlyWhenFocus`, but I believe that is a typo and should instead be `_renderLineHighlightOnlyWhenFocus`
Contributor
|
I believe you missed some... src/vs/editor/browser/viewParts/currentLineHighlight/currentLineHighlight.ts:
25 protected _selectionIsEmpty: boolean;
26: protected _renderLineHightlightOnlyWhenFocus: boolean;
27 protected _focused: boolean;
39 this._renderLineHighlight = options.get(EditorOption.renderLineHighlight);
40: this._renderLineHightlightOnlyWhenFocus = options.get(EditorOption.renderLineHighlightOnlyWhenFocus);
41 this._contentLeft = layoutInfo.contentLeft;
87 this._renderLineHighlight = options.get(EditorOption.renderLineHighlight);
88: this._renderLineHightlightOnlyWhenFocus = options.get(EditorOption.renderLineHighlightOnlyWhenFocus);
89 this._contentLeft = layoutInfo.contentLeft;
112 public onFocusChanged(e: viewEvents.ViewFocusChangedEvent): boolean {
113: if (!this._renderLineHightlightOnlyWhenFocus) {
114 return false;
172 && this._selectionIsEmpty
173: && (!this._renderLineHightlightOnlyWhenFocus || this._focused)
174 );
178 (this._renderLineHighlight === 'gutter' || this._renderLineHighlight === 'all')
179: && (!this._renderLineHightlightOnlyWhenFocus || this._focused)
180 );
191 (this._renderLineHighlight === 'gutter' || this._renderLineHighlight === 'all')
192: && (!this._renderLineHightlightOnlyWhenFocus || this._focused)
193 );
198 && this._selectionIsEmpty
199: && (!this._renderLineHightlightOnlyWhenFocus || this._focused)
200 ); |
alexdima
requested changes
Oct 12, 2020
Member
alexdima
left a comment
alexdima
left a comment
There was a problem hiding this comment.
There are some missed locations. Here are the build errors:
src/vs/editor/browser/viewParts/currentLineHighlight/currentLineHighlight.ts(88,8): error TS2551: Property '_renderLineHightlightOnlyWhenFocus' does not exist on type 'AbstractLineHighlightOverlay'. Did you mean '_renderLineHighlightOnlyWhenFocus'?
src/vs/editor/browser/viewParts/currentLineHighlight/currentLineHighlight.ts(113,13): error TS2551: Property '_renderLineHightlightOnlyWhenFocus' does not exist on type 'AbstractLineHighlightOverlay'. Did you mean '_renderLineHighlightOnlyWhenFocus'?
src/vs/editor/browser/viewParts/currentLineHighlight/currentLineHighlight.ts(173,14): error TS2551: Property '_renderLineHightlightOnlyWhenFocus' does not exist on type 'CurrentLineHighlightOverlay'. Did you mean '_renderLineHighlightOnlyWhenFocus'?
src/vs/editor/browser/viewParts/currentLineHighlight/currentLineHighlight.ts(179,14): error TS2551: Property '_renderLineHightlightOnlyWhenFocus' does not exist on type 'CurrentLineHighlightOverlay'. Did you mean '_renderLineHighlightOnlyWhenFocus'?
src/vs/editor/browser/viewParts/currentLineHighlight/currentLineHighlight.ts(192,14): error TS2551: Property '_renderLineHightlightOnlyWhenFocus' does not exist on type 'CurrentLineMarginHighlightOverlay'. Did you mean '_renderLineHighlightOnlyWhenFocus'?
src/vs/editor/browser/viewParts/currentLineHighlight/currentLineHighlight.ts(199,14): error TS2551: Property '_renderLineHightlightOnlyWhenFocus' does not exist on type 'CurrentLineMarginHighlightOverlay'. Did you mean '_renderLineHighlightOnlyWhenFocus'?
|
|
Contributor
Author
|
Oh. I'll make sure to remember to use It's now been fixed and the build CI now succeeds. |
Contributor
@justjosias Or use grep.app (Extended view) 😉 GitHub search sucks... |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original member was named
_renderLineHightlightOnlyWhenFocus, but I believe that is a typo and should instead be_renderLineHighlightOnlyWhenFocusInterestingly, I found this typo because I was trying to search for code related to highlighting, and made the same mistake, spelling it "hightlight", and this code appeared as a result.
I do not see
_renderLineHightlightOnlyWhenFocusreferenced elsewhere, so this fix should not cause any breakage.