Add Non-Wrapping EditorGroup-focus actions#108071
Merged
bpasero merged 7 commits intomicrosoft:masterfrom Oct 8, 2020
Merged
Conversation
|
|
bpasero
requested changes
Oct 5, 2020
| registry.registerWorkbenchAction(SyncActionDescriptor.from(FocusPreviousGroup), 'View: Focus Previous Editor Group', CATEGORIES.View.value); | ||
| registry.registerWorkbenchAction(SyncActionDescriptor.from(FocusNextGroup), 'View: Focus Next Editor Group', CATEGORIES.View.value); | ||
| registry.registerWorkbenchAction(SyncActionDescriptor.from(FocusLeftGroup, { primary: KeyChord(KeyMod.CtrlCmd | KeyCode.KEY_K, KeyMod.CtrlCmd | KeyCode.LeftArrow) }), 'View: Focus Left Editor Group', CATEGORIES.View.value); | ||
| registry.registerWorkbenchAction(SyncActionDescriptor.create(FocusLeftGroupWithoutWrap, FocusLeftGroupWithoutWrap.ID, undefined), 'View: Focus Left Editor Group Without Wrap', CATEGORIES.View.value); |
Member
There was a problem hiding this comment.
As I mentioned before, I do not feel like these commands should appear in the command palette but only be available as commands for someone to assign. I feel this is making the list of commands otherwise a lot more complex without much value.
Contributor
Author
There was a problem hiding this comment.
By not supplying a label, they do not appear in the command palette, don't they? How would i register the action otherwise?
Member
There was a problem hiding this comment.
@Agreon you can use CommandRegistry:
e.g.
vscode/src/vs/workbench/browser/parts/editor/editorCommands.ts
Lines 542 to 544 in 6173cf8
Member
|
Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #107873
The desired behaviour mentioned in the issue can be achieved by adding the new actions as key-bindings.