Skip to content

Add keybinding shortcut for "Preserve case" replace option#107597

Merged
roblourens merged 3 commits intomicrosoft:masterfrom
turara:resolve-107208
Oct 6, 2020
Merged

Add keybinding shortcut for "Preserve case" replace option#107597
roblourens merged 3 commits intomicrosoft:masterfrom
turara:resolve-107208

Conversation

@turara
Copy link
Contributor

@turara turara commented Sep 28, 2020

This PR resolves #107208 with

  • Adding "togglePreserveCase" command actions for editor and search view with default keybinding of "alt-(cmd)-p"
  • Adding keybinding label to ReplaceInput and ContextScopedReplaceInput classes.

@ghost
Copy link

ghost commented Sep 28, 2020

CLA assistant check
All CLA requirements met.

@turara
Copy link
Contributor Author

turara commented Sep 29, 2020

Related to #107588.

@turara
Copy link
Contributor Author

turara commented Sep 29, 2020

Is there anything I need to do about the failure of VS Code check?

@roblourens roblourens assigned roblourens and unassigned rebornix Sep 29, 2020
@roblourens roblourens requested a review from rebornix September 29, 2020 17:07
@roblourens
Copy link
Member

roblourens commented Sep 29, 2020

Looks good to me but we are in our endgame week for the next release and I will review and merge it next week. The CI failure looks unrelated.

@turara
Copy link
Contributor Author

turara commented Sep 30, 2020

Thanks! I see 😃

@roblourens roblourens added this to the October 2020 milestone Sep 30, 2020
@roblourens roblourens merged commit c7c471b into microsoft:master Oct 6, 2020
@turara
Copy link
Contributor Author

turara commented Oct 6, 2020

@roblourens Thank you for reviewing and merging! This is my first decent contribution to OSS. I'm very happy 😃

@roblourens
Copy link
Member

Congratulations! I hope to see more from you 😁

@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Preserve case" replace option : add a key shortcut

3 participants