Skip to content

hover info should not be broken within word#106885

Merged
mjbvz merged 1 commit intomicrosoft:masterfrom
Zuckjet:fix-hover-style
Nov 7, 2020
Merged

hover info should not be broken within word#106885
mjbvz merged 1 commit intomicrosoft:masterfrom
Zuckjet:fix-hover-style

Conversation

@Zuckjet
Copy link
Contributor

@Zuckjet Zuckjet commented Sep 16, 2020

Fix #105630

@Zuckjet
Copy link
Contributor Author

Zuckjet commented Sep 16, 2020

CI error " ##[error]PowerShell exited with code '1' " seems is not relevant my changes

@alexdima
Copy link
Member

I did a quick blame on the CSS and it looks like it was introduced via #74582

@rheh
Copy link

rheh commented Nov 6, 2020

The PR reserves the fix that rectified issue #74579 so does that need reopening/addressing? Is there a solution to fix both?

@Zuckjet
Copy link
Contributor Author

Zuckjet commented Nov 6, 2020

The PR reserves the fix that rectified issue #74579 so does that need reopening/addressing? Is there a solution to fix both?

the issue you posted is about adding word-wrap:break-word CSS property, but this PR is about removing word-break:break-all CSS property. I think they can work together.

@mjbvz mjbvz added this to the November 2020 milestone Nov 7, 2020
@mjbvz mjbvz merged commit a296377 into microsoft:master Nov 7, 2020
@mjbvz
Copy link
Collaborator

mjbvz commented Nov 7, 2020

Thanks. Let's see how this goes in insiders

@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript QuickInfo should not wrap in the middle of an operator

4 participants