Add isWritableFileSystem api#106378
Merged
jrieken merged 1 commit intomicrosoft:masterfrom Sep 10, 2020
Merged
Conversation
Fixes microsoft#91697 This new API checks if a given scheme allows writing
Collaborator
Author
|
@jrieken I took a look at the code but wasn't able to figure out how to synchronize the registered file systems across extension hosts. Let me know if you can look into this |
jrieken
reviewed
Sep 10, 2020
| * @param scheme The scheme of the filesystem, for example `file` or `git`. | ||
| * | ||
| * @return `true` if the file system supports writing, `false` if it does not | ||
| * support writing (i.e. it is readonly), and `undefined` if VS Code does not |
Member
There was a problem hiding this comment.
we shouldn't mention VS Code here, I usually say "the editor"
Member
Yeah, that's seems a little more complex than I though... I'm going to merge this one and make some more changes to sync all provider info from the renderer to extension hosts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #91697
This new API checks if a given scheme allows writing