SCM: Clear list of created resource groups once they are added#105587
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom Aug 31, 2020
Merged
SCM: Clear list of created resource groups once they are added#105587joaomoreno merged 1 commit intomicrosoft:masterfrom
joaomoreno merged 1 commit intomicrosoft:masterfrom
Conversation
This prevents them being re-added again next time fixes microsoft#105483
mjcrouch
changed the title
Member
|
Great fix, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
createdResourceGroupsmap was never cleared.This meant that every time a resource group was added, it would re-add all the resource groups that it added last time, and so on.
This PR fixes #105483
also fixes mjcrouch/vscode-perforce#179