Skip to content

105160: Support configuring keyboard overlay timeout + mouse indicator color/size#105219

Merged
lszomoru merged 3 commits intomicrosoft:masterfrom
neilenns:105160
Aug 31, 2020
Merged

105160: Support configuring keyboard overlay timeout + mouse indicator color/size#105219
lszomoru merged 3 commits intomicrosoft:masterfrom
neilenns:105160

Conversation

@neilenns
Copy link

@neilenns neilenns commented Aug 22, 2020

This PR fixes #105160

Adds support for configuring the timeout of the screencast mode overlay via settings. The default value of 800 is identical to the current hardcoded value for backwards compatibility.

I arbitrarily selected 500 (half a second) and 6000 (10 seconds) as the min and max valid values.

To test:

  1. Enable screencast mode
  2. Try setting the timeout to something larger than 800 (3000 is good to notice the difference)
  3. Type something (e.g. CTRL+P), confirm the overlay shows up then disappears after 5 seconds
  4. Type something (e.g. CTRL+P) repeatedly in a very short period. Confirm the overlay shows up and then disappears 5 seconds after the last keypress.
  5. Attempt to set a value lower than 500, confirm the settings UI prevents this and the previous value gets used
  6. Attempt to set a value higher than 6000, confirm the settings UI prevents this and the previous value gets used

@neilenns
Copy link
Author

neilenns commented Aug 22, 2020

Note that this PR will likely have merge conflicts with the one for #103307.

@sbatten sbatten assigned lszomoru and unassigned sbatten Aug 24, 2020
@lszomoru lszomoru self-requested a review August 24, 2020 15:38
@lszomoru lszomoru added the feature-request Request for new features or functionality label Aug 27, 2020
@lszomoru lszomoru added this to the August 2020 milestone Aug 27, 2020
@ghost
Copy link

ghost commented Aug 28, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@lszomoru
Copy link
Member

lszomoru commented Aug 28, 2020

@danecreekphotography, I have pushed a commit to the PR so that we subscribe to settings changes. Merging it.

@lszomoru
Copy link
Member

lszomoru commented Aug 28, 2020

@danecreekphotography can you please sign the CLA in this comment? Thanks!

@neilenns
Copy link
Author

neilenns commented Aug 28, 2020

I tried three times but it doesn't seem to work from the phone. I'll have to do it when I'm at a real computer later today.

@lszomoru lszomoru changed the title 105160: Support configuring screencast key overlay timeout 105160: Support configuring keyboard overlay timeout + mouse indicator color/size Aug 28, 2020
@lszomoru lszomoru mentioned this pull request Aug 28, 2020
Closed
@neilenns
Copy link
Author

neilenns commented Aug 28, 2020

@lszomoru CLA signed!

@lszomoru lszomoru merged commit bb6a143 into microsoft:master Aug 31, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lszomoru lszomoru lszomoru approved these changes

Assignees

@lszomoru lszomoru

Labels

feature-request Request for new features or functionality screencast-mode

Projects

None yet

Milestone

August 2020

Development

Successfully merging this pull request may close these issues.

Support configuring screencast key overlay timeout

3 participants

@neilenns @lszomoru @sbatten