Support \U\u\L\l replace modifiers in global search/replace (see PR #96128)#105101
Merged
roblourens merged 2 commits intomicrosoft:masterfrom Aug 25, 2020
irridia:irridia-feature-regex-caseops
Merged
Support \U\u\L\l replace modifiers in global search/replace (see PR #96128)#105101roblourens merged 2 commits intomicrosoft:masterfrom irridia:irridia-feature-regex-caseops
roblourens merged 2 commits intomicrosoft:masterfrom
irridia:irridia-feature-regex-caseops
Conversation
irridia
changed the title
Member
|
I need to spend some more time testing this but at first look it looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support \U\u\L\l modifiers to search replacement to alter word case in the global Find/Replace flow.
The behavior is patterned after Boost, but only applied to the replacement text, not subsequent content. Thus the \E isn't relevant. This is also vaguely similar to other replacement syntax, like pcre2 and perl.
For example, to export a file full of non-exported functions in a Go file:
Find:
^func (\w+)(
Replace:
func \u$1(
Example:
func myPrivateFunc(...
Result:
func MyPrivateFunc(...
With \U:
func MYPRIVATEFUNC(...
With \l\l\l\U:
func mypRIVATEFUNC(...
This PR broadens the implemetation as present in PR #96128.
@roblourens