feat(extensions): added an option to disable related dependencies when disabling an extension with enabled dependencies#104997
Merged
sandy081 merged 3 commits intomicrosoft:masterfrom Nov 11, 2020
rotem-bar:jensui/102906
Merged
feat(extensions): added an option to disable related dependencies when disabling an extension with enabled dependencies#104997sandy081 merged 3 commits intomicrosoft:masterfrom rotem-bar:jensui/102906
sandy081 merged 3 commits intomicrosoft:masterfrom
rotem-bar:jensui/102906
Conversation
…n disabling an extension with enabled dependencies
gjsjohnmurray
suggested changes
Oct 20, 2020
Contributor
gjsjohnmurray
left a comment
gjsjohnmurray
left a comment
There was a problem hiding this comment.
I also suggest updating the three message texts in getErrorMessageForDisablingAnExtensionWithDependents to add the word "alone" like this:
Cannot disable extension '{0}' alone.
@sandy081 this is still on the August 2020 milestone, and I hope it can be merged soon. It will be particularly useful when disabling an extension that is part of an extension pack. At the moment we have to find the pack, disable that, then return to disable the member extension that we want to turn off.
src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts
Outdated
Show resolved
Hide resolved
Member
|
Sorry for not tracking this. Will go through it in November. |
Co-authored-by: John Murray <[email protected]>
sandy081
approved these changes
Nov 11, 2020
Member
sandy081
left a comment
sandy081
left a comment
There was a problem hiding this comment.
Thanks for the PR. Changes LGTM.
There are some minor wording tweaks which I will do after merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #102906
Adds a "Disable all related dependencies" button to the "Cannot disable extension X. Extensions .. depend on this"
To test changes: attempt to disable the Git extension while having an extension that depends on it enabled (Git Blame, etc.)