Conversation
bpasero
changed the title
Member
Author
|
@alexdima thanks for jumping in, let me know I should review now and then we merge this? |
alexdima
approved these changes
Aug 26, 2020
Member
alexdima
left a comment
alexdima
left a comment
There was a problem hiding this comment.
👍 I've pushed some more changes on top:
- now going through the same code path as a native paste
- added support for "in-tab" smart paste (i.e. multicursor, language mode, paste on new line)
- added better handling for Firefox, where the clipboard service does not work because Firefox does not support
navigator.clipboard.readText()
Member
Author
|
@alexdima thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #82604
@alexdima would be happy for some initial feedback if this is the right direction. I have to admit that I do not fully understand the concept of "implementations" for actions, this was probably added for custom editors / notebooks later.
Things to do:
Unfortunately given the async nature of the clipboard service, we need to await the contents of the clipboard and this would trigger a permission dialog in browsers that the user can decline.