Silently ignore the screen size is bogus error in the Process Explorer#104277
Merged
RMacfarlane merged 1 commit intomasterfrom Aug 11, 2020
Merged
Silently ignore the screen size is bogus error in the Process Explorer#104277RMacfarlane merged 1 commit intomasterfrom
RMacfarlane merged 1 commit intomasterfrom
Conversation
Contributor
Author
|
@RMacfarlane I triggered a build, I can paste the link for it here. I'm not sure if this should be a candidate or not. 🤷♂️ |
9at8
changed the title
RMacfarlane
approved these changes
Aug 11, 2020
Contributor
RMacfarlane
left a comment
RMacfarlane
left a comment
There was a problem hiding this comment.
Awesome! I think this doesn't qualify as a candidate, but will merge it in for next month's release. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98590
What
This pr just ignores the "screen size is bogus" error.
We can try
spawninstead ofexec, which does not create a subshell.