Add check to ensure TS 4.0-RC and forward use '--serverMode'.#104123
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Aug 5, 2020
DanielRosenwasser:serverModeTS
Merged
Add check to ensure TS 4.0-RC and forward use '--serverMode'.#104123mjbvz merged 1 commit intomicrosoft:masterfrom DanielRosenwasser:serverModeTS
mjbvz merged 1 commit intomicrosoft:masterfrom
DanielRosenwasser:serverModeTS
Conversation
Member
Author
Collaborator
|
Thanks @DanielRosenwasser! I'll test this locally to make sure it does the correct thing |
Member
Author
|
My first PR in VS Code! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The semver thing is temporary. I think that in the future, you should be able to just make it 4.0.0 and use
gte.Also, haven't been able to test it out, I did the work in a codespace.
CC @mjbvz