Skip to content

Replace innerHTML with innerText when assigning non-html string#103841

Merged
jrieken merged 4 commits intomicrosoft:masterfrom
annkamsk:innerText-for-trivial-strings
Aug 12, 2020
Merged

Replace innerHTML with innerText when assigning non-html string#103841
jrieken merged 4 commits intomicrosoft:masterfrom
annkamsk:innerText-for-trivial-strings

Conversation

@annkamsk
Copy link
Copy Markdown
Contributor

@annkamsk annkamsk commented Aug 3, 2020

This PR fixes #103700
It replaces assignments of '', ' ' or ' ' to .innerHTML with assignments to .innerText

@ghost
Copy link
Copy Markdown

ghost commented Aug 3, 2020

CLA assistant check
All CLA requirements met.

@jrieken jrieken self-assigned this Aug 10, 2020
@jrieken jrieken added this to the August 2020 milestone Aug 10, 2020
@jrieken jrieken added the debt Code quality issues label Aug 12, 2020
@jrieken jrieken self-requested a review August 12, 2020 09:47
@jrieken jrieken merged commit a1b6553 into microsoft:master Aug 12, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

debt Code quality issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trusted Types compatibility: replace innerHTML with innerText when assigning non-html string

3 participants