Support quickpick on open anyways#103712
Merged
mjbvz merged 2 commits intomicrosoft:masterfrom Jul 31, 2020
lramos15:binaryquickpick
Merged
Support quickpick on open anyways#103712mjbvz merged 2 commits intomicrosoft:masterfrom lramos15:binaryquickpick
mjbvz merged 2 commits intomicrosoft:masterfrom
lramos15:binaryquickpick
Conversation
Member
|
I like this flow, good change 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a file is detected as binary and the user has an extension installed which contributes a custom editor for that file type we should display a quick pick when the user clicks open anyways. This helps with suggestions like this microsoft/vscode-hexeditor#31 which wishes to use a custom editor in these scenarios.
