Use the search order settings for the search editor#103627
Merged
JacksonKearl merged 3 commits intomicrosoft:masterfrom Aug 3, 2020
Merged
Use the search order settings for the search editor#103627JacksonKearl merged 3 commits intomicrosoft:masterfrom
JacksonKearl merged 3 commits intomicrosoft:masterfrom
Conversation
|
|
Before this change searches in the search editor would always be sorted with the default sort, now it respect the configuration in the search settings. Fixes microsoft#103625.
Contributor
Author
|
I cannot make sense of the test failures, are those tests flaky? |
JacksonKearl
suggested changes
Jul 30, 2020
Contributor
JacksonKearl
left a comment
JacksonKearl
left a comment
There was a problem hiding this comment.
Looks good overall, just a small nit.
src/vs/workbench/contrib/searchEditor/browser/searchEditorSerialization.ts
Outdated
Show resolved
Hide resolved
Contributor
|
Looks good, thanks for adding this! |
Contributor
|
And yes, the tests are flaky... 🙈🙉🙊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change searches in the search editor would always
be sorted with the default sort, now it respect the configuration
in the search settings.
This PR fixes #103625.