fix: add missing property to deserializeRunnable#103436
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom Jul 30, 2020
Merged
fix: add missing property to deserializeRunnable#103436joaomoreno merged 1 commit intomicrosoft:masterfrom
joaomoreno merged 1 commit intomicrosoft:masterfrom
Conversation
codebytere
force-pushed
the
fix-json-reporter
branch
from
e686067 to
3770547
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue present when running non-default Mocha reporters, including JSON.
Non-default reporters expect to see a
test.currentRetryfunction when deserializing, and it was not added indeserializeRunnablewhich caused it to error withtest.currentRetry is not a function.Now, the following:
./scripts/test.sh --reporter=json "Unit Tests"will produce the correct output in the expected JSON format.
cc @deepak1556