Add filename patterns for jsconfig.json#103360
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Jul 27, 2020
pastelmind:patch-1
Merged
Add filename patterns for jsconfig.json#103360mjbvz merged 1 commit intomicrosoft:masterfrom pastelmind:patch-1
mjbvz merged 1 commit intomicrosoft:masterfrom
pastelmind:patch-1
Conversation
Add alternative filename patterns for jsconfig.json that will be recognized as JSONC when opened. This mirrors the accepted filename patterns for tsconfig.json.
Collaborator
|
Thanks! |
pastelmind
added a commit
to pastelmind/d2calc
that referenced
this pull request
Aug 14, 2020
Since this file is used to emit type declarations from JavaScript files, not TypeScript, the "tsconfig.*.json" file name was misleading. Previously, however, I was forced to use "tsconfig.*.json" because VS Code did not recognize "jsconfig.*.json" as JSONC (JSON with Comments). This was fixed in microsoft/vscode#103360. Now that the change is shipped in VS Code 1.48, we can safely rename the file to jsconfig.build.json. Note: VS Code complains about the "declarationMap" property, because the JSON schema for jsconfig.json--provided by JSON Schema Store (https://www.schemastore.org/json/)--does not have it. This seems to be an oversight; I will submit a PR to remedy this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add alternative filename patterns for
jsconfig.jsonthat will be recognized as JSONC when opened. This mirrors the accepted filename patterns fortsconfig.json.This PR fixes #103240