[themeing] Use Object.create(null) instead of {} for TokenRegistry#103349
Merged
aeschli merged 2 commits intomicrosoft:masterfrom Aug 11, 2020
nrayburn-tech:semanticobjects
Merged
[themeing] Use Object.create(null) instead of {} for TokenRegistry#103349aeschli merged 2 commits intomicrosoft:masterfrom nrayburn-tech:semanticobjects
aeschli merged 2 commits intomicrosoft:masterfrom
nrayburn-tech:semanticobjects
Conversation
Contributor
|
Thanks @nrayburn-tech ! |
aeschli
added
bug
aeschli
changed the title
Member
|
Maybe it's time for native |
Contributor
Author
|
@jrieken where all would There are 180ish files that use Should I create an issue for this? |
Member
No please :-) We generally don't accept PRs that go across different ownerships and make changes like this. Tho, when revisiting "local" things, as it has been done here, it is always a good to consider to use modern JS |
Contributor
|
Thanks, no PR needed, I prefer object literals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces {} with Object.create(null), so that accessing the object can have properties defined that conflict with the prototype names.
constructor,toStringare examples.This PR fixes #103104