Treat all files with git{config,attributes,modules}/editorconfig extensions as properties files#103326
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom Jul 30, 2020
Merged
Conversation
…extensions as properties files
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #103042 (again), as I found more occurrences of the issue -
files with the extensions
.gitconfig,.gitattributes,.gitmodules,.editorconfigare not being considered of type Properties,unless they match that exact filename, with nothing before the dot.
How to test:
Create and open files named
john.gitconfig,server.gitattributes,client.gitmodules,windows.editorconfig.The language mode for them should be set to Properties.