Fix runtime exception and add Teams#103209
Merged
RMacfarlane merged 2 commits intomicrosoft:masterfrom Jul 27, 2020
pierceboggan:patch-1
Merged
Fix runtime exception and add Teams#103209RMacfarlane merged 2 commits intomicrosoft:masterfrom pierceboggan:patch-1
RMacfarlane merged 2 commits intomicrosoft:masterfrom
pierceboggan:patch-1
Conversation
IllusionMH
reviewed
Jul 23, 2020
src/vs/workbench/contrib/tags/electron-browser/workspaceTagsService.ts
Outdated
Show resolved
Hide resolved
…rvice.ts Co-authored-by: Andrii Dieiev <[email protected]>
Contributor
|
@RMacfarlane can you review the fix for the dependencies? I'm hitting an exception when I try to debug. |
RMacfarlane
approved these changes
Jul 27, 2020
Contributor
RMacfarlane
left a comment
RMacfarlane
left a comment
There was a problem hiding this comment.
Thanks @pierceboggan!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where line #450 causes a runtime exception, and adds reporting for the Teams Client SDK.