Clean up the dependency structure around the environment service#102928
Closed
inspirer wants to merge 2 commits intomicrosoft:masterfrom
Closed
Clean up the dependency structure around the environment service#102928inspirer wants to merge 2 commits intomicrosoft:masterfrom
inspirer wants to merge 2 commits intomicrosoft:masterfrom
Conversation
|
|
Member
|
@inspirer are the code layer rules in ESLint something to extract from this PR if they make sense individually? As for the rest, #102918 (comment) applies. |
Contributor
Author
|
Shall I extract the eslintrc change into a separate PR? I'll have to leave out the line that forbids |
Member
|
Sorry but I am going ahead to close this, I feel I need to think about this problem myself and would not accept help in form of a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #102918
I followed the example of INativeWorkbenchEnvironmentService and extracted IBrowserWorkbenchEnvironmentService, splitting the workspace configuration options into two files: vs/workbench/{common,browser}/options.ts. Maybe I should have used the 'Web' infix instead of 'Browser' to highlight that those are web-only components, not reusable in the electron version. I'm happy to follow up and update this pull request as needed.
This PR also adds missing code-import-patterns for the web version.
Now looking at the code one again, I wonder if we should promote all
commoncontributions relying on the common environment service's options tobrowseras they don't make much sense in other environments. This can be done in a separate step though. There are:vscode/src/vs/workbench/services/extensionManagement/common/extensionManagementServerService.ts
Line 41 in 4ecf61e