feat(quickinput): support codicons in prompt#102898
Closed
devanshj wants to merge 1 commit intomicrosoft:masterfrom
Closed
feat(quickinput): support codicons in prompt#102898devanshj wants to merge 1 commit intomicrosoft:masterfrom
devanshj wants to merge 1 commit intomicrosoft:masterfrom
Conversation
devanshj
commented
Jul 19, 2020
|
|
||
| .quick-input-message > .codicon { | ||
| margin: 0 0.2em; | ||
| vertical-align: text-bottom; |
Contributor
Author
devanshj
commented
Jul 19, 2020
| } | ||
|
|
||
| .quick-input-message > .codicon { | ||
| margin: 0 0.2em; |
9fc89e6 to
2827c98
Compare
Collaborator
|
Merged manually, thanks @devanshj! |
Contributor
Author
|
No problems! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #96430
Just to be clear the issue title starts with
InputBoxwhich might mean the genericInputBoxalthough that's not directly used inshowInputBox, quickinput'sInputBox(ui.inputBox) along with a message dom node (ui.message) exclusive to quickinput is used instead. So this PR adds support of codicons for quick input's prompt and not for genericInputBox.I think it's worth mentioning that quickinput should (afaict) use generic
InputBox's message for prompt which would also solve #82112, because the generic already supports rich text message. I might look into fixing this as well.How to test: