Merged
Conversation
mjbvz
reviewed
Jul 16, 2020
| } | ||
|
|
||
| const overrideToUse = typeof id === 'string' && allEditorOverrides.find(([_, entry]) => entry.id === id); | ||
| let overrideToUse; |
Collaborator
There was a problem hiding this comment.
@rebornix Would we ever want to show the reopen with prompt if there is only one override?
Collaborator
|
Merging this for insiders. Will see if it causes any issues for other flows, such as reopen with |
Member
|
@mjbvz +1 for this change, showing picker when there is only one view type is weird IMHO. Great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #102289 by open with the editor if it's the only one available.
To test it in the current master branch, disable the builtin "vscode-notebook-tests" extension and create a new file. It should open the new file without asking for picking editor.
Enable the "vscode-notebook-tests" extension will add two candidates to the editor list, when create new file the picker should show up again.