Skip to content

fix: remove flexbox to enable ellipsis#102640

Merged
isidorn merged 5 commits intomicrosoft:masterfrom
pfongkye:issue/#101352
Jul 29, 2020
Merged

fix: remove flexbox to enable ellipsis#102640
isidorn merged 5 commits intomicrosoft:masterfrom
pfongkye:issue/#101352

Conversation

@pfongkye
Copy link
Contributor

This PR fixes #101352

@pfongkye
Copy link
Contributor Author

pfongkye commented Jul 15, 2020

The proposed solution removes the use of flex container so that ellipsis works as expected. There's however a loss in the vertical centering of the badge that I didn't manage to solve. I tried the following in vain:

Any suggestions will be welcomed.

@pfongkye
Copy link
Contributor Author

The proposed solution removes the use of flex container so that ellipsis works as expected. There's however a loss in the vertical centering of the badge that I didn't manage to solve. I tried the following in vain:

Any suggestions will be welcomed.

I think I found a solution by removing the extra div element (unless there are side effects I'm not aware of).

Copy link
Collaborator

@isidorn isidorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have did an initial code review, once you tackle my comments I will test this out.
There are a lot of cases that should ideally work as before, when horizontal size gets limited less important elements should get hidden first and so on.

@isidorn
Copy link
Collaborator

isidorn commented Jul 27, 2020

Thanks for the PR!

@pfongkye pfongkye marked this pull request as draft July 27, 2020 18:42
@pfongkye pfongkye marked this pull request as ready for review July 27, 2020 20:20
@isidorn
Copy link
Collaborator

isidorn commented Jul 28, 2020

Thanks for making the changes. While I do agree that this fixes the original issue, this causes some other issues.
For example: when you hover over the stack frame, the whole line moves to the right, and the restart frame button is no longer nicely right aligned

Screenshot 2020-07-28 at 10 11 20

@pfongkye
Copy link
Contributor Author

Thanks for making the changes. While I do agree that this fixes the original issue, this causes some other issues.
For example: when you hover over the stack frame, the whole line moves to the right, and the restart frame button is no longer nicely right aligned

Screenshot 2020-07-28 at 10 11 20

I'll take a look and see what can be done.

@pfongkye pfongkye marked this pull request as draft July 28, 2020 08:20
@pfongkye pfongkye marked this pull request as ready for review July 28, 2020 19:56
@pfongkye
Copy link
Contributor Author

I think that with the new specificity for the state label, the rulesets will be applied properly.

@pfongkye pfongkye requested a review from isidorn July 28, 2020 19:58
@isidorn
Copy link
Collaborator

isidorn commented Jul 29, 2020

Thanks! I just tried this out and seems to work just fine.
Thus merging in ☀️

@isidorn isidorn merged commit 5dc7120 into microsoft:master Jul 29, 2020
@isidorn isidorn added this to the July 2020 milestone Jul 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pause on breakpoint badge should use text ellipsis

2 participants