only emit ctrl+h for cmd.exe when the terminal is in focus#102508
Merged
Tyriar merged 1 commit intomicrosoft:masterfrom Jul 14, 2020
Merged
only emit ctrl+h for cmd.exe when the terminal is in focus#102508Tyriar merged 1 commit intomicrosoft:masterfrom
Tyriar merged 1 commit intomicrosoft:masterfrom
Conversation
this resolves an issue introduced in microsoft#98494 in which ctrl+bksp would not delete a whole word when the currently open terminal was cmd.exe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves an issue introduced in #98494 in which ctrl+bksp, in the editor, would not delete a whole word when the currently open terminal was cmd.exe, regardless of focus.
I thought I had tested for this case, but it seems I changed some things while debugging and forgot to add back this part. I'm not sure of a way to unit test for this.
This pull request is related to issue #98404
@Tyriar