feat: Autodetect npm.packageManager #102050#102494
Conversation
|
|
shivangg
force-pushed
the
shivangg/feat-npm-auto
branch
2 times, most recently
from
4370595 to
beae5d1
Compare
|
Hey @alexr00 One of the check is waiting to be reported. Can you help me understand the reason for that. Also, is this blocking the PR review? |
shivangg
force-pushed
the
shivangg/feat-npm-auto
branch
from
3bc8341 to
fdbafbe
Compare
|
@alexr00 Could you please advise an update on this PR? |
|
Looks like there's a merge conflict in |
Using default import for minimatch to resolve `esModuleInterop` conflict
Detects the preferred package manager and if multiple are present, warns and uses in priority order: npm => yarn => pnpm
shivangg
force-pushed
the
shivangg/feat-npm-auto
branch
from
fdbafbe to
8a3a76b
Compare
|
@nickmccurdy @alexr00 Resolved the merge conflict. |
|
@alexr00 Is something pending on this PR? I'd love to resolve it. |
|
@shivangg thanks for your patience! I made a some changes to be consistent with the rest of the codebase and for some cleanup. I also have two changes requested from you. |
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
I addressed the last changes I wanted so that this can be merged.
|
@alexr00 with this do you think it's reasonable to expose a command for extensions to get the package manager? Previously in js-debug I was using the value of the setting, but this no longer works and the 'auto' resolution is not trivial enough I would want to copy-paste it into js-debug.
|
|
@connor4312 exposing a command to get the package manager seems perfectly reasonable. #109071 |
|
Reverted, we decided not to take on the additional dependencies. |
|
Will this feature still be implemented or are you looking for another implementation with less dependencies? |
|
We have no plans to implement it in any specific time frame, but since it's on the backlog we still want to implement it eventually. You can see our roadmap for the kinds of things we're planning on working on. |
|
In that case, would it be helpful if I recreated this pull request with fewer/no dependencies? I wanted to try it earlier but I'm new to VSCode development, though I think having this as a reference would help me. |
Detects the preferred package manager and if multiple are present, warns and uses in priority order: npm => yarn => pnpm Fixes #102050 Co-authored-by: Alex Ross <[email protected]>
|
I have re-merged this PR with bea7673 |
4 participants
This PR fixes #102050
npm.packageManagershould haveautooption and default to it.auto, check lock file to find preferred package manager.autoset and multiple lock files found.