fix styling to improve heading spacing fixes #102036#102427
Merged
mjbvz merged 3 commits intomicrosoft:masterfrom Jul 14, 2020
Merged
fix styling to improve heading spacing fixes #102036#102427mjbvz merged 3 commits intomicrosoft:masterfrom
mjbvz merged 3 commits intomicrosoft:masterfrom
Conversation
|
|
jasonwilliams
changed the title
jasonwilliams
changed the title
Collaborator
|
Looks good! Merged for the 1.48 insiders builds so we can make sure these changes work well out on real world markdown |
Charles-Gagnon
pushed a commit
to Charles-Gagnon/vscode
that referenced
this pull request
Jul 14, 2020
…oft#102427) * updating styling to make headings look better * be consistent and use em
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #102036
It made sense to remove the margin-top and let top elements push others down. (otherwise you fall into margin-collapse hell)
Before
After
pings @mjbvz