Skip to content

Fixes regression: cannot open image with special characters '#', '?', '%'#102189

Merged
mjbvz merged 5 commits intomicrosoft:masterfrom
jeanp413:fix-102188
Jul 24, 2020
Merged

Fixes regression: cannot open image with special characters '#', '?', '%'#102189
mjbvz merged 5 commits intomicrosoft:masterfrom
jeanp413:fix-102188

Conversation

@jeanp413
Copy link
Contributor

This PR fixes #102188

@tillig
Copy link

tillig commented Jul 14, 2020

Looks like #102442 just caused this to be in conflict. 😢

@jeanp413
Copy link
Contributor Author

@mjbvz not sure if you have this on you radar but just to be sure, could you take a look at this or the corresponding issue #102188 for the july release.
Opening images with filenames containing '#', '?', '%' worked fine in version 1.46 but stopped working in the 1.47 release.
Thanks

@mjbvz
Copy link
Collaborator

mjbvz commented Jul 22, 2020

Thanks for looking into this.

Since this was a regression, can you also look into adding a test for this so that we don't break this again. Here's the existing webview test for resource loading:

test('webviews should only be able to load resources from workspace by default', async () => {

In the testWorkspace directory, just create a new image file with a % and try loading that in the webview. You can run the tests using the single folder test option from the debug menu:

Screen Shot 2020-07-22 at 4 03 34 PM

@mjbvz mjbvz added this to the July 2020 milestone Jul 22, 2020
@jeanp413
Copy link
Contributor Author

Added the unit test.

@mjbvz mjbvz merged commit 86c04f7 into microsoft:master Jul 24, 2020
@mjbvz
Copy link
Collaborator

mjbvz commented Jul 24, 2020

Thanks!

@jeanp413 jeanp413 deleted the fix-102188 branch July 24, 2020 21:08
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: cannot open image with special characters '#', '?', '%'

3 participants