Fixes regression: cannot open image with special characters '#', '?', '%'#102189
Merged
mjbvz merged 5 commits intomicrosoft:masterfrom Jul 24, 2020
Merged
Fixes regression: cannot open image with special characters '#', '?', '%'#102189mjbvz merged 5 commits intomicrosoft:masterfrom
mjbvz merged 5 commits intomicrosoft:masterfrom
Conversation
|
Looks like #102442 just caused this to be in conflict. 😢 |
Contributor
Author
Collaborator
|
Thanks for looking into this. Since this was a regression, can you also look into adding a test for this so that we don't break this again. Here's the existing webview test for resource loading: In the |
Contributor
Author
|
Added the unit test. |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR fixes #102188