Skip to content

Only throw error if releaseNotesUrl doesn't exist#102149

Merged
joaomoreno merged 2 commits intomicrosoft:masterfrom
Charles-Gagnon:patch-1
Jul 21, 2020
Merged

Only throw error if releaseNotesUrl doesn't exist#102149
joaomoreno merged 2 commits intomicrosoft:masterfrom
Charles-Gagnon:patch-1

Conversation

@Charles-Gagnon
Copy link
Contributor

No description provided.

@SnirBroshi
Copy link
Contributor

SnirBroshi commented Jul 17, 2020

Haha oops, I guess @mjbvz and I didn't test #101158 that well, sorry.

I missed that possibility because releaseNotesUrl wasn't configured in my build, so I only tested it either successfully opened the release notes view inside the editor, or showed an error that it failed to fetch them and that this version doesn't have a release notes URL.

The await inside that if used to be a return, so this is a new bug.

@joaomoreno joaomoreno added this to the July 2020 milestone Jul 21, 2020
@joaomoreno
Copy link
Member

Thanks!

@joaomoreno joaomoreno merged commit 5c7e862 into microsoft:master Jul 21, 2020
@joaomoreno joaomoreno added the install-update VS Code installation and upgrade system issues label Jul 21, 2020
@Charles-Gagnon Charles-Gagnon deleted the patch-1 branch July 21, 2020 14:50
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

install-update VS Code installation and upgrade system issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants