Fixes quick find symbol finder shows 'no matching results' after backspace#101844
Merged
bpasero merged 2 commits intomicrosoft:masterfrom Jul 7, 2020
Merged
Fixes quick find symbol finder shows 'no matching results' after backspace#101844bpasero merged 2 commits intomicrosoft:masterfrom
bpasero merged 2 commits intomicrosoft:masterfrom
Conversation
Member
|
Thanks, I pushed a small change to only do this trick when we are in a editor symbol search 👍 |
gjsjohnmurray
pushed a commit
to gjsjohnmurray/vscode
that referenced
this pull request
Jul 8, 2020
…space (microsoft#101844) * Fixes microsoft#101708 * small polish Co-authored-by: Benjamin Pasero <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just validating that the
noResultsPickpick item does not get stored inthis.pickState.lastGlobalPicksseems to fix the issue.This PR fixes #101708