Skip to content

🆙 [email protected] (#33720)#101489

Merged
bpasero merged 1 commit intomasterfrom
ben/33720
Jul 3, 2020
Merged

🆙 [email protected] (#33720)#101489
bpasero merged 1 commit intomasterfrom
ben/33720

Conversation

@bpasero
Copy link
Member

@bpasero bpasero commented Jul 1, 2020

This PR fixes #33720

@bpasero bpasero added this to the July 2020 milestone Jul 1, 2020
@bpasero bpasero self-assigned this Jul 1, 2020
@bpasero
Copy link
Member Author

bpasero commented Jul 1, 2020

@gyzerok I believe this would allow us to remove this any cast:

const jschardetTypingsWorkaround = limitedBuffer.buffer as any;

However, the type is not clear, I think it must be string, why not Uint8Array?

@gyzerok
Copy link
Contributor

gyzerok commented Jul 1, 2020

@bpasero yeah you are right.

I was planning to update the version once we are finished with the PR I have currently open, but you beat me to it :)

However, the type is not clear, I think it must be string, why not Uint8Array?

It has to be string indeed. With Uint8Array it won't work. I misunderstood the source code and it is actually mistake on my side. It is fixed in the currently open PR as

const binaryString = encodeLatin1(limitedBuffer.buffer);

@bpasero
Copy link
Member Author

bpasero commented Jul 1, 2020

Oh yeah, forgot about that. This PR will not be merged until Friday or Monday next week since master is currently blocked for feature work.

@bpasero bpasero merged commit 1fb0d44 into master Jul 3, 2020
@bpasero bpasero deleted the ben/33720 branch July 3, 2020 13:53
@bpasero
Copy link
Member Author

bpasero commented Jul 3, 2020

@gyzerok fyi master is open for 1.48 July work, so feel free to remove that any cast in a new PR.

gjsjohnmurray pushed a commit to gjsjohnmurray/vscode that referenced this pull request Jul 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong guess encoding as Windows 1252

2 participants