Retry fetching release notes on failure, and display failures#101158
Merged
mjbvz merged 3 commits intomicrosoft:masterfrom Jun 26, 2020
Merged
Retry fetching release notes on failure, and display failures#101158mjbvz merged 3 commits intomicrosoft:masterfrom
mjbvz merged 3 commits intomicrosoft:masterfrom
Conversation
Collaborator
|
Thanks! Should be in the next insiders build and is scheduled for VS Code 1.47 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #101132
As you can see in the issue, this is how to test it:
Go offline (you can also open devtools in vscode and go to the network tab and change the "online" at the top to "offline")
Try to open the release notes using Show Release Notes from the command palette.
Depending on whether you are on an official vscode build or a local build, the release notes page will be opened in your default browser. On a local build it should show an error stating that fetching the release notes failed and that this vscode doesn't have release notes online.
Go back online
Try to open the release notes again
The release notes should open in a webview
Go offline again
Try to open the release notes again
The release notes should open in a webview again, even though we're offline