Skip to content

fix #100437 Improve 'terminal.integrated.commandsToSkipShell' info#100445

Merged
Tyriar merged 3 commits intomicrosoft:masterfrom
gjsjohnmurray:fix-100437
Jul 9, 2020
Merged

fix #100437 Improve 'terminal.integrated.commandsToSkipShell' info#100445
Tyriar merged 3 commits intomicrosoft:masterfrom
gjsjohnmurray:fix-100437

Conversation

@gjsjohnmurray
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray commented Jun 18, 2020

Improve 'terminal.integrated.commandsToSkipShell' information in Settings Editor

This PR fixes #100437

New display is:
image

Note the use of two command links to help user view the full list of defaults.

Previously it was:
image

@gjsjohnmurray
Copy link
Contributor Author

gjsjohnmurray commented Jun 18, 2020

@roblourens how about this?

@Tyriar
Copy link
Member

Tyriar commented Jun 18, 2020

I was thinking more pushing the [...] up and making it a link to expand the section fully.

@gjsjohnmurray
Copy link
Contributor Author

gjsjohnmurray commented Jun 18, 2020

I was thinking more pushing the [...] up and making it a link to expand the section fully.

@Tyriar fine by me, but maybe consider taking some/all of the revisions I've made to the preamble text in this PR?

@roblourens
Copy link
Member

roblourens commented Jun 18, 2020

Yeah I would rather not tell the user to click these links, but I'll leave it to @Tyriar whether he wants the text changes

@gjsjohnmurray
Copy link
Contributor Author

gjsjohnmurray commented Jun 18, 2020

Yeah I would rather not tell the user to click these links

Me too. If we could specify a command: URI that ran multiple commands, and if workbench.action.openRawDefaultSettings took a parameter that triggered a search, maybe it could be reduced to a single click.

Tyriar
Tyriar requested changes Jul 8, 2020
View reviewed changes
@Tyriar Tyriar added this to the July 2020 milestone Jul 8, 2020
Tyriar
Tyriar approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry about the delay

@Tyriar Tyriar merged commit 9e21a4e into microsoft:master Jul 9, 2020
@gjsjohnmurray gjsjohnmurray deleted the fix-100437 branch July 9, 2020 12:38
@gjsjohnmurray gjsjohnmurray mentioned this pull request Jul 25, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

July 2020

Development

Successfully merging this pull request may close these issues.

Settings editor only gives a partial list of the defaults for 'terminal.integrated.commandsToSkipShell'

3 participants

@gjsjohnmurray @Tyriar @roblourens