-
Notifications
You must be signed in to change notification settings - Fork 38.2k
Description
Issue Type: Bug
After updating to 1.43.0, when VSCode relaunched, it brought up around 80 editor windows from old projects I hadn't opened in quite some time. (spooky workspace necromancy)
Perhaps obviously this made my computer behave quite poorly. I tried adding "window.restoreWindows": "none" to my <config>/User/settings.json with another text editor, but it didn't seem to be respected (might be my fault somehow). Note that it had been on "folders" previously, in case that helps.
I also tried to muck about with <config>/storage.json file. VSCode seemed to ignore my changes to it (probably not a bug -- I was desparate and dunno how this file works), but I do have a backup of a storage.json from right after this happened. It shows all the windows it will try to open when launching, and maybe other stuff. If there's no PII concern beyond the file paths I can upload it. I guess the system info probably has more PII anyway. I dunno how much this helps but: https://gist.github.com/thomcc/c4f9a745d940d8e0bfd5d28946c73bdc
I think the main common feature of the workspaces it resurrected seemed to be that they had open files with unsaved changes -- but these are also the ones which can't be closed without additional UI confirmation, and I did try a couple things to close all windows in bulk (none seemed to work, but maybe I just didn't notice?)
Relaunching without extensions also didn't help, but that doesn't mean this wasn't caused by an extension in the first place or somethign. I have more than is probably reasonable installed. That said, it happening immediately after updating to 1.43.0 makes me think it's vscode and not an extension.
Anyway, ultimately I just bit the bullet and closed them manually -- VSCode would be usable for about 20 seconds after starting, during which time I could close a few before too many were restored and everything got too slow. So i just did this, quit, and repeated many times until there were no more left (this actually took a couple goes -- even when I'd get down to none left, save, and reopen, it would find some new ones to bring back... Guessing these just didn't make the cut for being restored the previous time, or something)
P.S. it would be nice if there were a command line argument to launch without reopening anything.
P.P.S. In case it isn't clear: I've been using editor, workspace, and window somewhat interchangably here, just so you don't think I'm being precise about which I use when.
VS Code version: Code 1.43.0 (78a4c91, 2020-03-09T19:34:44.548Z)
OS version: Darwin x64 18.7.0
System Info
| Item | Value |
|---|---|
| CPUs | Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz (12 x 2900) |
| GPU Status | 2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off_ok webgl: enabled webgl2: enabled |
| Load (avg) | 3, 21, 51 |
| Memory (System) | 32.00GB (2.52GB free) |
| Process Argv | |
| Screen Reader | no |
| VM | 0% |
Extensions (55)
| Extension | Author (truncated) | Version |
|---|---|---|
| code-gnu-global | aus | 0.2.2 |
| better-toml | bun | 0.3.2 |
| glsl-canvas | cir | 0.2.8 |
| bracket-pair-colorizer-2 | Coe | 0.0.29 |
| dart-code | Dar | 3.8.1 |
| xml | Dot | 2.5.0 |
| scopes | dua | 0.45.0 |
| gitlens | eam | 10.2.1 |
| vscode-html-css | ecm | 0.2.3 |
| tslint | eg2 | 1.0.44 |
| vsc-material-theme | Equ | 32.5.0 |
| vsc-material-theme-icons | equ | 1.1.4 |
| prettier-vscode | esb | 3.20.0 |
| vscode-test-explorer | hbe | 2.17.0 |
| vscode-peacock | joh | 3.6.0 |
| language-haskell | jus | 2.7.0 |
| center-editor-window | kai | 2.3.0 |
| chat | kar | 0.31.0 |
| restructuredtext | lex | 120.0.0 |
| fish-ide | lun | 0.4.0 |
| regionfolder | map | 1.0.8 |
| Kotlin | mat | 1.7.1 |
| rust-analyzer | mat | 0.1.20200309 |
| Lisp | mat | 0.1.10 |
| ninja-syntax | mel | 1.0.0 |
| prettify-json | moh | 0.0.3 |
| vscode-json5 | mrm | 1.0.0 |
| vscode-docker | ms- | 1.0.0 |
| csharp | ms- | 1.21.13 |
| sublime-keybindings | ms- | 4.0.6 |
| vscode-typescript-tslint-plugin | ms- | 1.2.3 |
| vsliveshare | ms- | 1.0.1711 |
| vsliveshare-audio | ms- | 0.1.80 |
| vsliveshare-pack | ms- | 0.3.4 |
| debugger-for-chrome | msj | 4.12.6 |
| idl | myt | 0.3.1 |
| autotrim | Nat | 1.0.6 |
| proto | pet | 0.0.2 |
| material-icon-theme | PKi | 4.0.1 |
| polacode | pnp | 0.3.4 |
| tcl | ras | 0.1.0 |
| crates | ser | 0.4.7 |
| trailing-spaces | sha | 0.3.1 |
| vscode-scheme | sjh | 0.4.0 |
| fish-vscode | sky | 0.2.1 |
| shader | sle | 1.1.4 |
| rewrap | stk | 1.9.1 |
| shellcheck | tim | 0.9.0 |
| org-mode | too | 0.5.0 |
| cmake | twx | 0.0.17 |
| vscode-lldb | vad | 1.5.0 |
| vscode-icons | vsc | 10.0.0 |
| material-theme | zhu | 3.2.3 |
| vscode-open-in-github | ziy | 1.3.6 |
| tslint-snippets | zuo | 1.1.0 |
(11 theme extensions excluded)