-
Notifications
You must be signed in to change notification settings - Fork 38.2k
Description
Complexity: 4
Tester1 - Gecko (Firefox)
Tester2 - WebKit (Safari)
Tester3 - Chromium (new Edge, Chrome, Opera)
FYI @chrisdias
Parts of this support came in via a PR and parts I did, but there isn't really any issue that we're testing because this wasn't officially on the plan. Trying things out a bit is interesting because we might want to consider using Shadow DOM internally, in VS Code.
To test, you need to:
- have vscode checked out and compiling via gulp watch
- clone https://github.com/microsoft/monaco-editor/ as a sibling to vscode
- in
monaco-editor, runnpm installandnpm run simpleserver - open http://127.0.0.1:8080/monaco-editor/test/shadow-dom.html?editor=src (it is important that editor=src is in there)
Then, simply try to do some things in the editor... We had to do special things around mouse handling and CSS as the shadow DOM nodes were hidden from the outer document, but there might be other things which could be broken... You can further try to do interesting things like changing the language or changing editor settings by editing the shadow-dom.html file.