Skip to content

Reveal in Sidebar crashes  #82290

@OmarTawfik

Description

@OmarTawfik
  • VSCode Version: 1.39
  • OS Version: Darwin x64 18.7.0

This doesn't happen consistently, but every once in a while, this feature would completely crash and I'd have to restart my editor. The steps are as follows:

  • I open a folder, I start editing some code.
  • I right click the tab name, and click Reveal in Sidebar.
  • The whole File explorer is highlighted in blue, without my file actually getting highlighted.

I checked the dev tools, and here is the error that gets shown:

  ERR TreeError [FileExplorer] Data tree node not found: [object Object]: Error: TreeError [FileExplorer] Data tree node not found: [object Object]
    at WorkbenchAsyncDataTree.getDataNode (file:///Applications/VS Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:64272:23)
    at WorkbenchAsyncDataTree.reveal (file:///Applications/VS Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:64253:35)
    at ExplorerView.onSelectResource (file:///Applications/VS Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:292485:31)

I traced it down to this line:

throw new TreeError(this.user, `Data tree node not found: ${element}`);

Which indiates that tree items are refreshed/updated somehow, but the key used to look up this map is still referring to the old object? Should this map be indexed by something else? item id (string)?

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions