-
Notifications
You must be signed in to change notification settings - Fork 38.2k
Closed
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugsearchSearch widget and operation issuesSearch widget and operation issuesverifiedVerification succeededVerification succeeded
Milestone
Description
@roblourens ,
Replace string functionality in search does not work properly for hyphen and underscore separated variables , Initially figured it out from this comment
Example:
- Replacing
Foo-Bartotest-replacewith preserve case turned on replaces correctly toTest-Replace - Replacing
foo-Bartotest-replacewith preserve case turned on replaces incorrectly totest-replaceinstead oftest-Replace
PS : Additional Info from the code
I found out there is a bug in buildReplaceStringWithCasePreserved function.
The whole idea to call the replacement function again at this line was to reuse the already existing replacement logic ( First char capital , full caps and full small) but there was a bug as the hyphens and underscores were not even called because of wrong ordering in the condition checking logic.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugsearchSearch widget and operation issuesSearch widget and operation issuesverifiedVerification succeededVerification succeeded