- VSCode Version: Code 1.36.1 (2213894, 2019-07-08T22:59:35.033Z)
- OS Version: Windows_NT x64 10.0.17763
Steps to Reproduce:
- Open some file in VSCode
- Press Ctrl+Space
- Touch some completion item. Nothing happens
If you don't have a touch device, you can open dev tools (Ctrl+Shift+I) and click Toggle device toolbar to emulate touch.
The issue is in SuggestWidget - it disables mouseSupport and then only handles mouse events (but mouseSupport also handles touch events)
|
this.list = new List(this.listElement, this, [renderer], { |
|
useShadows: false, |
|
openController: { shouldOpen: () => false }, |
|
mouseSupport: false |
|
}); |
|
|
|
this.toDispose.add(attachListStyler(this.list, themeService, { |
|
listInactiveFocusBackground: editorSuggestWidgetSelectedBackground, |
|
listInactiveFocusOutline: activeContrastBorder |
|
})); |
|
this.toDispose.add(themeService.onThemeChange(t => this.onThemeChange(t))); |
|
this.toDispose.add(editor.onDidLayoutChange(() => this.onEditorLayoutChange())); |
|
this.toDispose.add(this.list.onMouseDown(e => this.onListMouseDown(e))); |
|
this.toDispose.add(this.list.onSelectionChange(e => this.onListSelection(e))); |
|
this.toDispose.add(this.list.onFocusChange(e => this.onListFocus(e))); |
|
this.toDispose.add(this.editor.onDidChangeCursorSelection(() => this.onCursorSelectionChanged())); |
|
this.toDispose.add(this.editor.onDidChangeConfiguration(e => e.contribInfo && applyIconStyle())); |
This was already once fixed in list widget (#9338), but then broken again in suggest widget.
