Right now the vscode terminal searches by starting at the top of the viewport, find next (enter) will search down and then wrap around to the top and keep search. This complicates a lot and causes obscure issues like xtermjs/xterm.js#2325. I also find when using search that I always use shift+enter as I want find previous.

Turns out this is how a lot of terminals work, they bind find previous to enter and will start from the bottom of the terminal buffer. shift+enter will start from the very top and search down.